Add other client extensions #637
Open
+253
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to use interfaces for enhanced flexibility and testability across various components like NatsJSContext and NatsConnection. Added new extension methods to easily create contexts for Object Store, Key-Value Store, and Services on NATS client and connection instances.
Updated INatsObjStore, INatsKVContext, and INatsSvcContext interfaces to include public `Context` properties. This change ensures consistent access to the underlying context objects across various components.
|
🙌 looking forward to this! |
rickdotnet
approved these changes
Sep 23, 2024
| /// <summary> | ||
| /// Provides access to the JetStream context associated with the Key-Value Store operations. | ||
| /// </summary> | ||
| INatsJSContext Context { get; } |
There was a problem hiding this comment.
This makes sense to me, but wondering what you think about folks using code like
var context = client.CreateKeyValueStoreContext();
...
var jsContext = context.Context;I don't mind it, but the thought came to mind and figured I'd mention it.
There was a problem hiding this comment.
What about JetStreamContext or just JetStream?
var context = client.CreateKeyValueStoreContext();
...
var jsContext = context.JetStreamContext;
...
var jsContext = context.JetStream;| public NatsKVContext(NatsJSContext context) => _context = context; | ||
| public NatsKVContext(INatsJSContext context) => Context = context; | ||
|
|
||
| /// <inheritdoc /> |
There was a problem hiding this comment.
My OCD thanks you for this. Prob don't need to, but could do the rest while you're here. ;) Might make sense as a separate maintenance PR.
There was a problem hiding this comment.
Do you mean using the new type constructors (or whatever they're called)?
| /// <param name="client">The NATS client instance.</param> | ||
| /// <returns>An instance of <see cref="INatsKVContext"/> which can be used to interact with the Key-Value Store.</returns> | ||
| public static INatsKVContext CreateKeyValueStoreContext(this INatsClient client) | ||
| => CreateKeyValueStoreContext(client.Connection); |
There was a problem hiding this comment.
Does it make sense to chain these to the JS extensions?
public static INatsKVContext CreateKeyValueStoreContext(this INatsClient client)
=> CreateKeyValueStoreContext(client.CreateJetStreamContext());
public static INatsKVContext CreateKeyValueStoreContext(this INatsConnection connection)
=> CreateKeyValueStoreContext(connection.CreateJetStreamContext());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use interfaces for enhanced flexibility and testability across various components like NatsJSContext and NatsConnection. Added new extension methods to easily create contexts for Object Store, Key-Value Store, and Services on NATS client and connection instances.